Skip to content

Conversation

@NataliaIvakina
Copy link
Collaborator

@NataliaIvakina NataliaIvakina commented Jan 13, 2025

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Jan 13, 2025

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@nick-giles-neo nick-giles-neo self-assigned this Jan 13, 2025
Copy link
Contributor

@nick-giles-neo nick-giles-neo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change itself looks fine. However, I noticed some related changes that could also be made

The showTopologyGraphConfig procedure on that page talks about the allocator too, and that output parameter has been removed.

allocator | STRING | The name of the allocator.

And the initial.dbms.database_allocator configuration setting has been removed too.

Don't know whether those are for this PR, or another one.

@NataliaIvakina
Copy link
Collaborator Author

The showTopologyGraphConfig procedure on that page talks about the allocator too, and that output parameter has been removed.

allocator | STRING | The name of the allocator.

And the initial.dbms.database_allocator configuration setting has been removed too.

Thank you for a thorough review. I'll remove the output parameter in this PR. The initial.dbms.database_allocator configuration setting will be covered in another PR.

@NataliaIvakina
Copy link
Collaborator Author

NataliaIvakina commented Jan 14, 2025

@nick-giles-neo, are you sure that the output parameter allocator for the showTopologyGraphConfig procedure has been removed? It's still in the code. I'll make a note for myself about this parameter (not to forget). But I also believe that our test will show if any argument is removed. We're testing them and their descriptions.

@NataliaIvakina NataliaIvakina merged commit a89f2f4 into neo4j:dev Jan 14, 2025
8 checks passed
@NataliaIvakina NataliaIvakina deleted the dev-remove-procedure branch January 14, 2025 09:18
@nick-giles-neo
Copy link
Contributor

@nick-giles-neo, are you sure that the output parameter allocator for the showTopologyGraphConfig procedure has been removed? It's still in the code. I'll make a note for myself about this parameter (not to forget). But I also think our test will show if any argument is removed. We're testing them and their descriptions.

Oh, no you are right. It's removed from the internal object (TopologyGraphSettings), but still present in the procedure return object (ShowTopologyGraphConfig). Sorry about that. Well, guess we missed the chance to remove that until the next LTS!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants